feat: Implement user-specific control for quality check button visibility on manufacturing orders and inventory transfers via a new allowed_quality_checks field on users.

README.md

@@ -10,7 +10,7 @@ Restrict visibility of the following records based on User configuration:
 *   **Locations** (`stock.location`)
 *   **Work Centers** (`mrp.workcenter`)
 *   **Approval Categories** (`approval.category`)
-*   **Quality Checks Button** (on Manufacturing Orders)
+*   **Quality Checks Button** (on Manufacturing Orders and Inventory Transfers)
 
 ## Configuration
 
@@ -32,12 +32,13 @@ Restrict visibility of the following records based on User configuration:
 
 ## Quality Checks Button Restriction
 
-The "Quality Checks" button on Manufacturing Orders is automatically hidden for users who belong to the following groups:
+The visibility of the "Quality Checks" and "Quality Alert" buttons on **Manufacturing Orders** and **Inventory Transfers** is controlled by a specific user setting.
-*   **Inventory User**
-*   **Manufacturing User**
-*   **MPS User**
 
-**Exception**: If a user in these groups is *also* assigned the **Quality User** or **Quality Manager** role, the button will remain visible.
+To allow a user to see these buttons:
+1.  Navigate to **Settings > Users & Companies > Users**.
+2.  Enable the checkbox **"Is Allowed todo Quality Checks?"** in the **Access Restrictions** tab.
+
+By default, this setting is unchecked, meaning users will **NOT** see these buttons unless explicitly allowed.
 
 ## Technical Details
 

__manifest__.py

@@ -16,13 +16,14 @@
     """,
     'category': 'Extra Tools',
     'author': 'Suherdy Yacob',
-    'depends': ['base', 'stock', 'mrp', 'approvals', 'stock_account', 'sale', 'quality_mrp'],
+    'depends': ['base', 'stock', 'mrp', 'approvals', 'stock_account', 'sale', 'quality_mrp', 'quality_control'],
     'data': [
         'security/ir.model.access.csv',
         'security/ir_rule.xml',
         'security/ir_actions_act_window.xml',
         'views/res_users_views.xml',
         'views/mrp_production_views.xml',
+        'views/stock_picking_views.xml',
     ],
     'installable': True,
     'application': False,

models/__init__.py

@@ -2,4 +2,5 @@ from . import res_users
 from . import restricted_models
 from . import sale_order
 from . import mrp_production
+from . import stock_picking
 

models/mrp_production.py

@@ -5,59 +5,11 @@ class MrpProduction(models.Model):
 
     hide_quality_check_button = fields.Boolean(compute='_compute_hide_quality_check_button')
 
+    @api.depends('product_id')
     @api.depends_context('uid')
     def _compute_hide_quality_check_button(self):
         for record in self:
-            user = self.env.user
+            # Logic: Hide logic is inverse of "is allowed"
-            
+            # If allowed_quality_checks is True, hide = False
-            # Define the restricted groups
+            # If allowed_quality_checks is False, hide = True
-            # 1. Inventory User (stock.group_stock_user)
+            record.hide_quality_check_button = not self.env.user.allowed_quality_checks
-            # 2. Manufacturing User (mrp.group_mrp_user)
-            # 3. MPS User (mrp_mps.group_mrp_mps) - handled safely
-            
-            is_restricted = False
-            
-            if user.has_group('stock.group_stock_user') or user.has_group('mrp.group_mrp_user'):
-                is_restricted = True
-            
-            # Check MPS User group safely as it might not be installed or ID might differ
-            if not is_restricted:
-                if user.has_group('mrp_mps.group_mrp_mps'):
-                    is_restricted = True
-                else:
-                    # Fallback search by name if XML ID not found or module not standard in this env
-                    if self.env['res.groups'].search_count([('name', '=', 'MPS User'), ('id', 'in', user.groups_id.ids)]):
-                        is_restricted = True
-            
-            # Logic: If user is in ANY of the restricted groups, we hide the button.
-            # However, usually "Manager" groups inherit "User" groups. 
-            # So a Manager would also be a User. 
-            # We must Ensure that we DO NOT hide it if the user is a Quality Manager or Quality User?
-            # The request says: "only hide ... from user in inventory user group, manufacturing user group and MPS user group"
-            # It implies if I am ONLY one of those, I shouldn't see it.
-            # But if I am ALSO a Quality User, should I see it?
-            # Usually, Quality User > Inventory User regarding Quality checks.
-            # If I hide it for Inventory User, and I am both Inventory User AND Quality User, I will simply NOT see it if I check "if has_group(Inventory)".
-            # So I should probably check if the user is NOT a Quality User/Manager.
-            
-            # But the user request is specific: "change the logic... to only hide ... from user in [groups]"
-            # If I am an Inventory User, I shouldn't see it.
-            # If I am also a Quality User, do I see it? Standard Odoo: Quality Users see it.
-            # If the user wants to restriction, likely they want these specific functional users NOT to do quality checks 
-            # UNLESS they are explicitly Quality Users?
-            # Or maybe they want to hide it EVEN IF they are Quality Users?
-            # "Only hide ... from user in ..." suggests targeting these specific roles.
-            
-            # Let's refine the logic:
-            # Hide IF (User is Inventory OR Mfg OR MPS) AND (User is NOT Quality Manager/User?)
-            # Or is it a hard hide? "Only hide ... from [list]"
-            # If I assume the user implies "People who are just Inventory/Mfg/MPS users shouldn't see this", 
-            # then if someone is ALSO a Quality Manager, they should probably see it.
-            # So I will add an exception: If user is Quality User+, they see it.
-            
-            is_quality_user = user.has_group('quality.group_quality_user') or user.has_group('quality.group_quality_manager')
-            
-            if is_restricted and not is_quality_user:
-                record.hide_quality_check_button = True
-            else:
-                record.hide_quality_check_button = False

models/res_users.py

@@ -47,3 +47,9 @@ class ResUsers(models.Model):
         string="Allowed Approvals",
         help="Approval Categories this user is allowed to access. Leave empty to restrict access to none."
     )
+
+    allowed_quality_checks = fields.Boolean(
+        string="Is Allowed todo Quality Checks?",
+        default=False,
+        help="If checked, this user can see the Quality Checks button on Manufacturing Orders."
+    )

models/stock_picking.py

@@ -0,0 +1,12 @@
+from odoo import models, fields, api
+
+class StockPicking(models.Model):
+    _inherit = 'stock.picking'
+
+    hide_quality_check_button = fields.Boolean(compute='_compute_hide_quality_check_button')
+
+    @api.depends('picking_type_id')
+    @api.depends_context('uid')
+    def _compute_hide_quality_check_button(self):
+        for record in self:
+            record.hide_quality_check_button = not self.env.user.allowed_quality_checks

views/mrp_production_views.xml

@@ -3,9 +3,10 @@
     <record id="mrp_production_view_form_inherit_access_restriction" model="ir.ui.view">
         <field name="name">mrp.production.view.form.inherit.access.restriction</field>
         <field name="model">mrp.production</field>
-        <field name="inherit_id" ref="quality_mrp.mrp_production_view_form_inherit_quality"/>
+        <field name="priority">99999</field>
+        <field name="inherit_id" ref="mrp.mrp_production_form_view"/>
         <field name="arch" type="xml">
-            <xpath expr="//header" position="inside">
+            <xpath expr="//sheet" position="inside">
                 <field name="hide_quality_check_button" invisible="1"/>
             </xpath>
             <xpath expr="//button[@name='check_quality']" position="attributes">

views/res_users_views.xml

@@ -16,6 +16,7 @@
                         <group string="Manufacturing &amp; others">
                             <field name="allowed_workcenter_ids" widget="many2many_tags"/>
                             <field name="allowed_approval_category_ids" widget="many2many_tags"/>
+                            <field name="allowed_quality_checks"/>
                         </group>
                     </group>
                 </page>

views/stock_picking_views.xml

@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <record id="stock_picking_view_form_inherit_access_restriction" model="ir.ui.view">
+        <field name="name">stock.picking.view.form.inherit.access.restriction</field>
+        <field name="model">stock.picking</field>
+        <field name="priority">1000</field>
+        <field name="inherit_id" ref="stock.view_picking_form"/>
+        <field name="arch" type="xml">
+            <xpath expr="//sheet" position="inside">
+                <field name="hide_quality_check_button" invisible="1"/>
+            </xpath>
+            <xpath expr="//button[@name='check_quality']" position="attributes">
+                <attribute name="invisible">hide_quality_check_button</attribute>
+            </xpath>
+             <xpath expr="//button[@name='button_quality_alert']" position="attributes">
+                <attribute name="invisible">hide_quality_check_button</attribute>
+            </xpath>
+        </field>
+    </record>
+</odoo>