From 4a049d124ecf9a3830893431fa442bba4d4ecb4b Mon Sep 17 00:00:00 2001 From: Suherdy Yacob Date: Mon, 19 Jan 2026 09:23:32 +0700 Subject: [PATCH] feat: Implement user-specific control for quality check button visibility on manufacturing orders and inventory transfers via a new `allowed_quality_checks` field on users. --- README.md | 13 +++-- __manifest__.py | 3 +- models/__init__.py | 1 + models/__pycache__/__init__.cpython-312.pyc | Bin 337 -> 374 bytes models/__pycache__/res_users.cpython-312.pyc | Bin 1932 -> 2172 bytes models/mrp_production.py | 58 ++----------------- models/res_users.py | 6 ++ models/stock_picking.py | 12 ++++ views/mrp_production_views.xml | 5 +- views/res_users_views.xml | 1 + views/stock_picking_views.xml | 20 +++++++ 11 files changed, 57 insertions(+), 62 deletions(-) create mode 100644 models/stock_picking.py create mode 100644 views/stock_picking_views.xml diff --git a/README.md b/README.md index 7a6d9fb..dc48563 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ Restrict visibility of the following records based on User configuration: * **Locations** (`stock.location`) * **Work Centers** (`mrp.workcenter`) * **Approval Categories** (`approval.category`) -* **Quality Checks Button** (on Manufacturing Orders) +* **Quality Checks Button** (on Manufacturing Orders and Inventory Transfers) ## Configuration @@ -32,12 +32,13 @@ Restrict visibility of the following records based on User configuration: ## Quality Checks Button Restriction -The "Quality Checks" button on Manufacturing Orders is automatically hidden for users who belong to the following groups: -* **Inventory User** -* **Manufacturing User** -* **MPS User** +The visibility of the "Quality Checks" and "Quality Alert" buttons on **Manufacturing Orders** and **Inventory Transfers** is controlled by a specific user setting. -**Exception**: If a user in these groups is *also* assigned the **Quality User** or **Quality Manager** role, the button will remain visible. +To allow a user to see these buttons: +1. Navigate to **Settings > Users & Companies > Users**. +2. Enable the checkbox **"Is Allowed todo Quality Checks?"** in the **Access Restrictions** tab. + +By default, this setting is unchecked, meaning users will **NOT** see these buttons unless explicitly allowed. ## Technical Details diff --git a/__manifest__.py b/__manifest__.py index ca0a458..70e244f 100644 --- a/__manifest__.py +++ b/__manifest__.py @@ -16,13 +16,14 @@ """, 'category': 'Extra Tools', 'author': 'Suherdy Yacob', - 'depends': ['base', 'stock', 'mrp', 'approvals', 'stock_account', 'sale', 'quality_mrp'], + 'depends': ['base', 'stock', 'mrp', 'approvals', 'stock_account', 'sale', 'quality_mrp', 'quality_control'], 'data': [ 'security/ir.model.access.csv', 'security/ir_rule.xml', 'security/ir_actions_act_window.xml', 'views/res_users_views.xml', 'views/mrp_production_views.xml', + 'views/stock_picking_views.xml', ], 'installable': True, 'application': False, diff --git a/models/__init__.py b/models/__init__.py index 94a4606..d5afda8 100644 --- a/models/__init__.py +++ b/models/__init__.py @@ -2,4 +2,5 @@ from . import res_users from . import restricted_models from . import sale_order from . import mrp_production +from . import stock_picking diff --git a/models/__pycache__/__init__.cpython-312.pyc b/models/__pycache__/__init__.cpython-312.pyc index 644f3df66c67991a3f13fea078666c603bcb9949..78e580eabf8314b295fe242a9a74a187a5f49ac9 100644 GIT binary patch delta 133 zcmcb}^o@!4G%qg~0}%N2=4N(JvN0adu zZ*fU}a&~+{W^#6BUb>$q+bxD7W}xOG77)P-BG^C#`^3G4YCJ#|BM=vh0ErLGjEszT W8N}~0$lqm#2x$q delta 96 zcmeyybdiboG%qg~0}y!3%*@Q6$ScWcGEv=>rIJ;XZDNkQn4c!=ErudypnMSvh+qW~ oY!mMnDsux_j6hs02qZo*Gcq#XWe~s1Ab*!Z;vR!c5hqX-01O)w;s5{u diff --git a/models/__pycache__/res_users.cpython-312.pyc b/models/__pycache__/res_users.cpython-312.pyc index 620603c45a557d4dc929185ae8ec7cff7721ece6..b7feec66487b71ed1024e9881f0d5949ab991e1a 100644 GIT binary patch delta 375 zcmeC-|0BS6nwOW00SKmb?Mkx`F{A(bUd3?zdJQe;!)QsmbttY(IY zNAXlDYAS7>%hx7brsdD9Y0b4rT1fm}aL-pMMgdlYW5JLTu+q$cLw5=(@*E4~oo zq`Gs5P_&5XOjZ*W6E^agMI7j_mowu>xMMM{$u z*)^OMfrb|;fe2+F@r%PIH$SB`C)KV<4aj8#;$jIP@qw9LIFtp;;_lhPbtkwwJTBvav6cRSOQ3VU}j`w Zyw4#2g+-5%t)r~JrnBZN1CR;U2>=tSAv*v7 diff --git a/models/mrp_production.py b/models/mrp_production.py index 69eacd7..27a8b0e 100644 --- a/models/mrp_production.py +++ b/models/mrp_production.py @@ -5,59 +5,11 @@ class MrpProduction(models.Model): hide_quality_check_button = fields.Boolean(compute='_compute_hide_quality_check_button') + @api.depends('product_id') @api.depends_context('uid') def _compute_hide_quality_check_button(self): for record in self: - user = self.env.user - - # Define the restricted groups - # 1. Inventory User (stock.group_stock_user) - # 2. Manufacturing User (mrp.group_mrp_user) - # 3. MPS User (mrp_mps.group_mrp_mps) - handled safely - - is_restricted = False - - if user.has_group('stock.group_stock_user') or user.has_group('mrp.group_mrp_user'): - is_restricted = True - - # Check MPS User group safely as it might not be installed or ID might differ - if not is_restricted: - if user.has_group('mrp_mps.group_mrp_mps'): - is_restricted = True - else: - # Fallback search by name if XML ID not found or module not standard in this env - if self.env['res.groups'].search_count([('name', '=', 'MPS User'), ('id', 'in', user.groups_id.ids)]): - is_restricted = True - - # Logic: If user is in ANY of the restricted groups, we hide the button. - # However, usually "Manager" groups inherit "User" groups. - # So a Manager would also be a User. - # We must Ensure that we DO NOT hide it if the user is a Quality Manager or Quality User? - # The request says: "only hide ... from user in inventory user group, manufacturing user group and MPS user group" - # It implies if I am ONLY one of those, I shouldn't see it. - # But if I am ALSO a Quality User, should I see it? - # Usually, Quality User > Inventory User regarding Quality checks. - # If I hide it for Inventory User, and I am both Inventory User AND Quality User, I will simply NOT see it if I check "if has_group(Inventory)". - # So I should probably check if the user is NOT a Quality User/Manager. - - # But the user request is specific: "change the logic... to only hide ... from user in [groups]" - # If I am an Inventory User, I shouldn't see it. - # If I am also a Quality User, do I see it? Standard Odoo: Quality Users see it. - # If the user wants to restriction, likely they want these specific functional users NOT to do quality checks - # UNLESS they are explicitly Quality Users? - # Or maybe they want to hide it EVEN IF they are Quality Users? - # "Only hide ... from user in ..." suggests targeting these specific roles. - - # Let's refine the logic: - # Hide IF (User is Inventory OR Mfg OR MPS) AND (User is NOT Quality Manager/User?) - # Or is it a hard hide? "Only hide ... from [list]" - # If I assume the user implies "People who are just Inventory/Mfg/MPS users shouldn't see this", - # then if someone is ALSO a Quality Manager, they should probably see it. - # So I will add an exception: If user is Quality User+, they see it. - - is_quality_user = user.has_group('quality.group_quality_user') or user.has_group('quality.group_quality_manager') - - if is_restricted and not is_quality_user: - record.hide_quality_check_button = True - else: - record.hide_quality_check_button = False + # Logic: Hide logic is inverse of "is allowed" + # If allowed_quality_checks is True, hide = False + # If allowed_quality_checks is False, hide = True + record.hide_quality_check_button = not self.env.user.allowed_quality_checks diff --git a/models/res_users.py b/models/res_users.py index a50010c..1b3c7d7 100644 --- a/models/res_users.py +++ b/models/res_users.py @@ -47,3 +47,9 @@ class ResUsers(models.Model): string="Allowed Approvals", help="Approval Categories this user is allowed to access. Leave empty to restrict access to none." ) + + allowed_quality_checks = fields.Boolean( + string="Is Allowed todo Quality Checks?", + default=False, + help="If checked, this user can see the Quality Checks button on Manufacturing Orders." + ) diff --git a/models/stock_picking.py b/models/stock_picking.py new file mode 100644 index 0000000..f759da1 --- /dev/null +++ b/models/stock_picking.py @@ -0,0 +1,12 @@ +from odoo import models, fields, api + +class StockPicking(models.Model): + _inherit = 'stock.picking' + + hide_quality_check_button = fields.Boolean(compute='_compute_hide_quality_check_button') + + @api.depends('picking_type_id') + @api.depends_context('uid') + def _compute_hide_quality_check_button(self): + for record in self: + record.hide_quality_check_button = not self.env.user.allowed_quality_checks diff --git a/views/mrp_production_views.xml b/views/mrp_production_views.xml index f74f2e2..29c627f 100644 --- a/views/mrp_production_views.xml +++ b/views/mrp_production_views.xml @@ -3,9 +3,10 @@ mrp.production.view.form.inherit.access.restriction mrp.production - + 99999 + - + diff --git a/views/res_users_views.xml b/views/res_users_views.xml index 6ca0e38..59ab6d9 100644 --- a/views/res_users_views.xml +++ b/views/res_users_views.xml @@ -16,6 +16,7 @@ + diff --git a/views/stock_picking_views.xml b/views/stock_picking_views.xml new file mode 100644 index 0000000..6a5df0c --- /dev/null +++ b/views/stock_picking_views.xml @@ -0,0 +1,20 @@ + + + + stock.picking.view.form.inherit.access.restriction + stock.picking + 1000 + + + + + + + hide_quality_check_button + + + hide_quality_check_button + + + +