From 43b6ab10dbd6271ef7303b5bed1d43a2faa7c205 Mon Sep 17 00:00:00 2001
From: Suherdy Yacob <suherdy.yacob@mapan.co.id>
Date: Wed, 21 Jan 2026 10:57:40 +0700
Subject: [PATCH] feat: Upgrade module to Odoo 19, updating view definitions
 from tree to list and refining account domains.

---
 .gitignore                                 |  0
 AMOUNT_FIX_GUIDE.md                        |  0
 CHANGELOG.md                               |  0
 README.md                                  |  0
 __init__.py                                |  0
 __manifest__.py                            |  2 +-
 fix_amount_issue.py                        |  0
 models/__init__.py                         |  0
 models/account_batch_payment.py            |  0
 models/account_payment.py                  |  0
 models/payment_deduction_line.py           |  2 +-
 security/ir.model.access.csv               |  0
 tests/__init__.py                          |  0
 tests/test_account_payment.py              |  0
 tests/test_batch_payment_integration.py    |  0
 views/account_batch_payment_views.xml      | 12 ++++++------
 views/account_payment_views.xml            |  4 ++--
 wizard/__init__.py                         |  0
 wizard/payment_amount_fix_wizard.py        |  0
 wizard/payment_amount_fix_wizard_views.xml |  4 ++--
 20 files changed, 12 insertions(+), 12 deletions(-)
 mode change 100644 => 100755 .gitignore
 mode change 100644 => 100755 AMOUNT_FIX_GUIDE.md
 mode change 100644 => 100755 CHANGELOG.md
 mode change 100644 => 100755 README.md
 mode change 100644 => 100755 __init__.py
 mode change 100644 => 100755 __manifest__.py
 mode change 100644 => 100755 fix_amount_issue.py
 mode change 100644 => 100755 models/__init__.py
 mode change 100644 => 100755 models/account_batch_payment.py
 mode change 100644 => 100755 models/account_payment.py
 mode change 100644 => 100755 models/payment_deduction_line.py
 mode change 100644 => 100755 security/ir.model.access.csv
 mode change 100644 => 100755 tests/__init__.py
 mode change 100644 => 100755 tests/test_account_payment.py
 mode change 100644 => 100755 tests/test_batch_payment_integration.py
 mode change 100644 => 100755 views/account_batch_payment_views.xml
 mode change 100644 => 100755 views/account_payment_views.xml
 mode change 100644 => 100755 wizard/__init__.py
 mode change 100644 => 100755 wizard/payment_amount_fix_wizard.py
 mode change 100644 => 100755 wizard/payment_amount_fix_wizard_views.xml

diff --git a/.gitignore b/.gitignore
old mode 100644
new mode 100755
diff --git a/AMOUNT_FIX_GUIDE.md b/AMOUNT_FIX_GUIDE.md
old mode 100644
new mode 100755
diff --git a/CHANGELOG.md b/CHANGELOG.md
old mode 100644
new mode 100755
diff --git a/README.md b/README.md
old mode 100644
new mode 100755
diff --git a/__init__.py b/__init__.py
old mode 100644
new mode 100755
diff --git a/__manifest__.py b/__manifest__.py
old mode 100644
new mode 100755
index ad51deb..0a64f69
--- a/__manifest__.py
+++ b/__manifest__.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 {
     'name': 'Vendor Payment Diff Amount',
-    'version': '17.0.2.1.0',
+    'version': '19.0.2.1.0',
     'category': 'Accounting/Accounting',
     'summary': 'Support multiple payment deductions for vendor payments (withholding tax, fees, etc.)',
     'description': """
diff --git a/fix_amount_issue.py b/fix_amount_issue.py
old mode 100644
new mode 100755
diff --git a/models/__init__.py b/models/__init__.py
old mode 100644
new mode 100755
diff --git a/models/account_batch_payment.py b/models/account_batch_payment.py
old mode 100644
new mode 100755
diff --git a/models/account_payment.py b/models/account_payment.py
old mode 100644
new mode 100755
diff --git a/models/payment_deduction_line.py b/models/payment_deduction_line.py
old mode 100644
new mode 100755
index 889daa5..c0a5d68
--- a/models/payment_deduction_line.py
+++ b/models/payment_deduction_line.py
@@ -58,7 +58,7 @@ class PaymentDeductionLine(models.Model):
         'account.account',
         string='Deduction Account',
         required=True,
-        domain="[('account_type', 'not in', ['asset_cash', 'asset_cash_bank', 'asset_receivable', 'liability_payable']), ('deprecated', '=', False)]",
+        domain="[('account_type', 'not in', ['asset_cash', 'asset_cash_bank', 'asset_receivable', 'liability_payable'])]",
         help='Account where the deduction will be recorded (use tax payable or expense accounts, NOT payable/receivable accounts)',
     )
     name = fields.Char(
diff --git a/security/ir.model.access.csv b/security/ir.model.access.csv
old mode 100644
new mode 100755
diff --git a/tests/__init__.py b/tests/__init__.py
old mode 100644
new mode 100755
diff --git a/tests/test_account_payment.py b/tests/test_account_payment.py
old mode 100644
new mode 100755
diff --git a/tests/test_batch_payment_integration.py b/tests/test_batch_payment_integration.py
old mode 100644
new mode 100755
diff --git a/views/account_batch_payment_views.xml b/views/account_batch_payment_views.xml
old mode 100644
new mode 100755
index 06011fb..69f0356
--- a/views/account_batch_payment_views.xml
+++ b/views/account_batch_payment_views.xml
@@ -1,15 +1,15 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
-    <!-- Add deduction lines field to batch payment line tree view -->
+    <!-- Add deduction lines field to batch payment line list view -->
     <record id="view_batch_payment_form_inherit_diff_amount" model="ir.ui.view">
         <field name="name">account.batch.payment.form.inherit.diff.amount</field>
         <field name="model">account.batch.payment</field>
         <field name="inherit_id" ref="vendor_batch_payment_merge.view_batch_payment_form_inherit"/>
         <field name="arch" type="xml">
-            <!-- Replace the tree view with one that includes a form view for deduction lines -->
+            <!-- Replace the list view with one that includes a form view for deduction lines -->
             <xpath expr="//field[@name='direct_payment_line_ids']" position="replace">
                 <field name="direct_payment_line_ids">
-                    <tree editable="bottom">
+                    <list editable="bottom">
                         <field name="partner_id" domain="parent.batch_type == 'outbound' and [('supplier_rank', '>', 0)] or [('customer_rank', '>', 0)]" options="{'no_create': True}"/>
                         <field name="amount" sum="Total"/>
                         <field name="expense_account_id"/>
@@ -17,7 +17,7 @@
                         <field name="memo"/>
                         <field name="date"/>
                         <field name="payment_id" readonly="1"/>
-                    </tree>
+                    </list>
                     <form>
                         <group>
                             <group name="payment_info">
@@ -32,13 +32,13 @@
                         </group>
                         <group string="Deductions" name="deductions">
                             <field name="deduction_line_ids" nolabel="1" context="{'default_currency_id': currency_id}">
-                                <tree editable="bottom">
+                                <list editable="bottom">
                                     <field name="sequence" widget="handle"/>
                                     <field name="substract_account_id" required="1"/>
                                     <field name="name" placeholder="Description (optional)"/>
                                     <field name="amount_substract" required="1" sum="Total"/>
                                     <field name="currency_id" column_invisible="1"/>
-                                </tree>
+                                </list>
                             </field>
                             <field name="amount_substract" readonly="1"/>
                         </group>
diff --git a/views/account_payment_views.xml b/views/account_payment_views.xml
old mode 100644
new mode 100755
index 2286184..22b39b5
--- a/views/account_payment_views.xml
+++ b/views/account_payment_views.xml
@@ -12,14 +12,14 @@
                        invisible="payment_type != 'outbound'"
                        readonly="state != 'draft'"
                        nolabel="1">
-                    <tree editable="bottom">
+                    <list editable="bottom">
                         <field name="sequence" widget="handle"/>
                         <field name="substract_account_id" required="1"/>
                         <field name="name" placeholder="Description (optional)"/>
                         <field name="amount_substract" required="1" sum="Total Deductions"/>
                         <field name="currency_id" column_invisible="1"/>
                         <field name="company_id" column_invisible="1"/>
-                    </tree>
+                    </list>
                 </field>
                 
                 <label for="amount_substract" string="Total Deductions" 
diff --git a/wizard/__init__.py b/wizard/__init__.py
old mode 100644
new mode 100755
diff --git a/wizard/payment_amount_fix_wizard.py b/wizard/payment_amount_fix_wizard.py
old mode 100644
new mode 100755
diff --git a/wizard/payment_amount_fix_wizard_views.xml b/wizard/payment_amount_fix_wizard_views.xml
old mode 100644
new mode 100755
index 87ffbea..4165cdf
--- a/wizard/payment_amount_fix_wizard_views.xml
+++ b/wizard/payment_amount_fix_wizard_views.xml
@@ -12,14 +12,14 @@
                 </p>
                 <group>
                     <field name="payment_ids" nolabel="1">
-                        <tree>
+                        <list>
                             <field name="name"/>
                             <field name="partner_id"/>
                             <field name="amount"/>
                             <field name="amount_substract"/>
                             <field name="final_payment_amount"/>
                             <field name="date"/>
-                        </tree>
+                        </list>
                     </field>
                 </group>
                 <footer>