admin.suherdy/pos_loyalty_discount_before_tax
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: recalculate order price totals to prevent stale value usage during synchronous reward line replacement

Browse Source
This commit is contained in:
Suherdy Yacob 2026-06-16 15:09:09 +07:00
parent 228a84c867
commit 792cb4be74
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
static/src/overrides/models/loyalty.js
View File

@ -175,8 +175,15 @@ patch(PosOrder.prototype, {
let { discountable, discountablePerTax } = getDiscountable(reward); let { discountable, discountablePerTax } = getDiscountable(reward);
// Use priceExcl instead of priceIncl for maximum limit comparison // Compute real order totals to avoid stale values during synchronous reward line replacement.
discountable = Math.min(this.priceExcl, discountable); // When _updateRewardLines deletes the old reward lines, order.triggerRecomputeAllPrices()
// queues a microtask. However, _applyReward runs synchronously right after line.delete().
// Thus, this.priceExcl and this.priceIncl are stale and include the deleted reward lines.
const realPriceExcl = this.getOrderlines().reduce((sum, line) => sum + line.priceExcl, 0);
const realPriceIncl = this.getOrderlines().reduce((sum, line) => sum + line.priceIncl, 0);
// Use realPriceExcl instead of priceIncl for maximum limit comparison
discountable = Math.min(realPriceExcl, discountable);
if (Math.abs(discountable) < 0.0001) { if (Math.abs(discountable) < 0.0001) {
return []; return [];
@ -244,9 +251,9 @@ patch(PosOrder.prototype, {
taxIds = this.pos.taxes.filter((tax) => taxIds.includes(tax.id)); taxIds = this.pos.taxes.filter((tax) => taxIds.includes(tax.id));
} }
var discount_amount = -(Math.min(this.priceIncl, entry[1]) * discountFactor); var discount_amount = -(Math.min(realPriceIncl, entry[1]) * discountFactor);
console.log("DEBUG LOYALTY:", { console.log("DEBUG LOYALTY:", {
discountable, maxDiscount, discountFactor, priceIncl: this.priceIncl, entry_1: entry[1], discount_amount discountable, maxDiscount, discountFactor, priceIncl: realPriceIncl, entry_1: entry[1], discount_amount
}); });
// OVERRIDE: Inject JSON variables (will be automatically assigned in Odoo 19 extraFields, we must make sure these properties are forwarded) // OVERRIDE: Inject JSON variables (will be automatically assigned in Odoo 19 extraFields, we must make sure these properties are forwarded)
lst.push({ lst.push({