From 59e9ea98a9cc650889e52aec0132b934fb7b443a Mon Sep 17 00:00:00 2001 From: Suherdy Yacob Date: Mon, 8 Jun 2026 11:31:41 +0700 Subject: [PATCH] fix: prevent interaction with reward and negative price lines in split bill screen --- static/src/app/models/pos_order_line.js | 3 +-- static/src/app/screens/split_bill_screen/split_bill_screen.js | 2 +- static/src/app/screens/split_bill_screen/split_bill_screen.xml | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/static/src/app/models/pos_order_line.js b/static/src/app/models/pos_order_line.js index 012addd..c8aed08 100644 --- a/static/src/app/models/pos_order_line.js +++ b/static/src/app/models/pos_order_line.js @@ -6,8 +6,7 @@ patch(PosOrderline.prototype, { return ( this.is_reward_line || (this.config.discount_product_id && this.product_id.id === this.config.discount_product_id.id) || - this.price_unit < 0 || - this.prices?.total_included < 0 + this.price_unit < 0 ); }, diff --git a/static/src/app/screens/split_bill_screen/split_bill_screen.js b/static/src/app/screens/split_bill_screen/split_bill_screen.js index e576632..25e9b99 100644 --- a/static/src/app/screens/split_bill_screen/split_bill_screen.js +++ b/static/src/app/screens/split_bill_screen/split_bill_screen.js @@ -5,7 +5,7 @@ import { SplitBillScreen } from "@pos_restaurant/app/screens/split_bill_screen/s patch(SplitBillScreen.prototype, { onClickLine(line) { - if (line.isDiscountLine) { + if (line.isDiscountLine || line.is_reward_line || (line.prices && line.prices.total_included < 0)) { return; } super.onClickLine(...arguments); diff --git a/static/src/app/screens/split_bill_screen/split_bill_screen.xml b/static/src/app/screens/split_bill_screen/split_bill_screen.xml index 726154f..0c0cfa8 100644 --- a/static/src/app/screens/split_bill_screen/split_bill_screen.xml +++ b/static/src/app/screens/split_bill_screen/split_bill_screen.xml @@ -2,7 +2,7 @@ - !line.isDiscountLine + !line.isDiscountLine && !line.is_reward_line && (line.prices ? line.prices.total_included >= 0 : true)